chore(deps): refresh browser tooling and CI dependencies - #38
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: chore(deps): refresh browser tooling and CI dependencies This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refresh the browser helper's dependency graph and CI tools, preserving the existing Bun root / npm transcript-helper split. The compiled helper passes a real Chrome navigation and DOM evaluation. Full local checks also caught a stale npm authentication fixture; it now asserts the existing environment-based registry contract and exact command arguments, while retaining the token-isolation assertions.
Dependency changes
Regenerated
bun.lockwithbun update --latest.npm updateleft the transcript package manifest/lockfile unchanged. Commander 15.0.0 and youtube-transcript-plus 2.0.1 are already current; checkout v7 and setup-bun v2 already track the latest release majors. No direct dependencies were added or removed. Node 24 remains the CI compatibility baseline; local validation used Node 26.8.1 and Bun 1.4.0.Major review: setup-node v7 migrates the action to ESM; this workflow uses supported inputs and does not rely on the removed dummy authentication variable. The transitive string-width v8 requires Node 20, below our existing runtime baseline. Puppeteer release notes and Bun 1.4 release notes were checked. No declared dependency major was skipped.
Local validation
Shell syntax validation passed for 26 scripts. In
skills/video-transcript-downloader,npm cireported zero vulnerabilities, the dynamic import confirmedYoutubeTranscript.fetchTranscriptis a function, and./scripts/vtd.js transcript --helpprinted its expected usage. Release tests use mock credentials/tools; inherited service credentials were removed for the fixture run. That test emits a pre-existing grep diagnostic about treating command text as a filename, but exits successfully.The project-structure self-test passed all five checks with its documented external TypeScript prerequisite supplied through
npm exec --yes --package=typescript@6.0.3andNODE_PATH, without adding a repository dependency. Follow-up for Peter: TypeScript 7.0.2 no longer exposescreateSourceFile/ScriptTarget; the optional mapper produces an empty TypeScript map with it. Recommend retaining TypeScript 6 for this helper until a separate compiler-API migration is designed. This is outside the declared dependency graph and was not changed here.Live proof
Launched a fresh headless Chrome with
puppeteer.launch, the installed Chrome executable, and--remote-debugging-port=0; closed it infinally. These are the actual compiled-binary commands and outputs from that session:The harness parsed the returned JSON and asserted both values were
Example Domain. Chrome used a fresh temporary profile; no existing browser session was used.CI reasoning
Default-branch CI was green before this change: run 33337744072. The repository has one build/test/smoke workflow and no scheduled operations/monitoring workflows. All existing jobs and assertions remain enabled. The broader local suite exceeds the workflow's current smoke coverage.
Codex autoreview completed with
scoped-clean, no accepted/actionable findings at its requested default P0 threshold. This is internal dependency maintenance with no intentional CLI behavior change, so no changelog entry is needed. PR is for maintainer review; do not merge automatically.PR CI is now green: run 33368061945 passed on commit
594d91ec453199efe0ffeaa228ec9e1b1065a708, verifying setup-node v7, Bun 1.4.0, the compiled browser helper, all existing CI tests, and transcript-helper installation/smoke checks on Ubuntu. No CI reruns or weakened checks were needed. Defaultmainwas not modified or merged.